Samy started his career at El Khatib Football Academy, after playing well and showing great discipline in the Pepsi Schools League. Before participating in the Pepsi Schools League he had a trial with Egyptian giants Al Ahly youth team, but failed to pass all tests because of an injury. After staying with El Khatib Football Academy for almost 4 years, he was signed by Al Nasr at the age of 15.
On 1 July 2012, Samy was transferred to newly-promoted team Telephonat Beni Suef. This was considered as the first season for the club at the Egyptian Premier League, because after the club gained promotion to the 2011–12 Egyptian Premier League by winning the 2010–11 Egyptian Second Division, the season was suspended in February 2012 and all league results were halted due to the incidents that occurred during the Port Said Stadium riot. The next season, 2011–12 Egyptian Premier League, wasn't much different; as the Egyptian Premier League, alongside all other sport-related activities in Egypt, were cancelled and all results were halted in July 2013 for security reasons due to the 2013 Egyptian coup d'état. Things became a bit stable 2013–14 Egyptian Premier League, but because the season started on 26 December 2013 the Egyptian Football Association decided to split the teams in two groups to make sure that the season will end in July 2014. Samy had a decent season with club, he scored 1 goal and missed only 3 matches in the season. The club finished 9th in Group B and lost the relegation play-off against El Raja and were relegated to the Egyptian Second Division. A lot of clubs wanted to sign Samy after the season ended, including Al Ahly, Ismaily and Misr Lel Makkasa. After Ehab Galal, who managed Telephonat Beni Suef in the 2013–14 season, was appointed as manager of Misr Lel Makkasa; Samy ended up joining Misr Lel Makkasa too after he was convinced by Galal to join him with his new club.
Misr Lel Makkasa
On 3 August 2014, Misr Lel Makkasa completed the signing of Samy in a 3-year contract alongside some of his teammates at Telephonat Beni Suef, including future club star Ahmed El Sheikh. Samy made his official debut in the first match of the 2014–15 Egyptian Premier League season in a 2–1 win against El Raja, playing the full 90 minutes in that match. Samy became an important player in the team quickly, and played 35 official matches in his first season with the club, including 32 in the league. After a great first season, the club finished fourth in the league and qualified for the 2016 CAF Confederation Cup, their first ever appearance in an African competition. Samy maintained his first-eleven place for the 2015–16 Egyptian Premier League after gaining his manager's trust after his performance in the previous season. In the 2015–16 season he played 29 league matches and scored 2 goals, against Ittihad El Shorta in a 1–1 draw in the first match of the season and against league champions Al Ahly in a 0–1 away win. Despite his performance, the club didn't do well in local competitions as they finished 10th in the league and got eliminated from the 2015–16 Egypt Cupin the Round of 32 by Egyptian Second Division side FC Masr. The club reached the Play-off round in the 2016 CAF Confederation Cup after beating Defence Force of Ethiopia, CS Don Bosco of DR Congo and CS Constantine of Algeria in the Preliminary round, First round and Second round respectively; but failed to make it to the group stage as they were eliminated by Al Ahli Tripoli of Libya after the Libyan club won on away goals. Samy played only 24 league matches in the 2016–17 Egyptian Premier League season due to suspension and a foot injury; but he maintained his good performance in both centre-back and defensive midfielder positions and helped his club to finish the league in the 2nd place and to qualify for the 2018 CAF Champions League for the first time in the club history. Al Ahly made a bid for Samy at the end of the season, but the club refused the offer and renewed his contract. On 3 March 2017, during Misr Lel Makkasa and Zamalekleague match, Samy made controversies after he cleared a cross from a free-kick with his hand. All Zamalek players ran to the referee asking for a penalty, but the international referee Gehad Grisha didn't give it because he didn't see it and gave a corner instead. The match ended as a 1–0 win for Misr Lel Makkasa. Samy was announced as the club's new captain for the 2017–18 Egyptian Premier League season, after spending more that 3 years with the club. Many important players left Misr Lel Makkasa after the club announced the departure of coach Ehab Galal, as left the club by mutual consent; players including top goalscorer Ahmed El Sheikh, playmakers Hussein El Shahat and Emad Fathy and goalkeeper Ahmed Masoud; which led to instability in the team. On 30 December 2017, Samy alongside other players from the Egyptian Premier League and other Arab leagues played for Al Ahly against Atlético Madrid in a friendly match under the slogan "Peace Against Terrorism" at Borg El Arab Stadium in Alexandria. The match ended 3–2 for Atlético Madrid.
International career
Although Samy never represented the senior team, he was called to play two non-official matches with the national team against Yemen on 13 May 2017 and against Libya on 5 June 2017.
