Born in Holytown, North Lanarkshire, McShane started his football career as an amateur with Bellshill Athletic, before turning professional at Blackburn Rovers in April 1937. During the Second World War, he guested for Manchester City, Blackpool, Reading and Port Vale. After the war ended he joined Huddersfield Town, and made 15 appearances in the First Division in the 1946–47 season, scoring one goal in a 5–2 win over Derby County at Leeds Road on 11 September. After recovering from a broken arm, he moved on to league rivals Bolton Wanderers in 1947. Walter Rowley's "Trotters" finished in 17th place in 1947–48, 14th place in 1948–49, and 16th place in 1949–50. He scored six goals in 93 league games during his spell at Burnden Park. McShane joined Manchester United in exchange for defender John Ball and £5,000 in September 1950. He was signed to replace the departing Charlie Mitten. He scored seven goals in 31 appearances in the 1950–51 season, as the "Red Devils" finished second in the league. His first goal at Old Trafford came on 7 October 1950, in a 3–1 win over Sheffield Wednesday. He was part of the United side that won the First Division title in 1951–52, scoring one goal in 12 league games that season. His goal was an important one, as it came against rivals Manchester City in a 2–1 win at Maine Road on 15 September. He then struggled with a cartilage injury, and appeared just five times in the 1952–53 campaign, as Matt Busby's side dropped to eighth place. McShane failed to break into the first team in the 1953–54 season, and in February 1954 was transferred to George Hardwick's Oldham Athletic for £750. The "Latics" were relegated out of the Second Division at the end of the 1953–54 season, and then finished tenth in the Third Division North in 1954–55. McShane scored five goals in 41 league games during his time at Boundary Park. He later played non-league football for Chorley, Wellington Town, and Droylsden.
Post-retirement
After retiring as a player, McShane became the coach of Stalybridge Celtic. He then worked as a talent scout for Manchester United, where he was credited with bringing Wes Brown to the management's attention. He was also an announcer at Old Trafford during the 1960s. He died in November 2012, aged 92 after suffering from Alzheimer's disease.
