Lang was born in March 1851 in Scotland. Before his football career, he worked at the John Brown & Company's shipyard on the River Clyde in Glasgow, where he lost sight in one eye due to an accident in 1869.
Football career
Club career
Lang's playing career started with Glasgow's Eastern, from where he moved to Clydesdale and then Third Lanark. While with Clydesdale he played in the first ever Scottish Cup final in 1874, losing 2–0 against Queen's Park. He also became involved with the Glasgow vs. Sheffield association matches, and at the 1876 meeting he caught the attention of The Wednesday board. They subsequently invited him to play for their team. He was not paid by the club but instead gained employment with a company in Garden Street owned by one of the directors, Walter Fearnehough. Although the family business manufactured "Bayonet Spirals, Ledger Blades and Chaff Knives" Lang received no formal duties and he spent most of the day reading the paper. The first mention of Lang playing for Wednesday was a friendly against local rivals Hallam on 25 November 1876. While he appeared for Wednesday throughout the 1876–77 season, featuring in "six friendly matches, four cup ties, two representative fixtures and one benefit game", he also made two appearances for Chesterfield Spital during December 1876. Lang returned to Third Lanark in October 1877 and played in their 1878 Scottish Cup Final defeat to Vale of Leven. Despite returning north of the border, Lang still featured for The Wednesday in 1878, playing in three Sheffield Challenge Cup matches, including the final in which Wednesday beat Attercliffe 2–0. While still at Third Lanark, Lang played once more for Wednesday in January 1879 against Heeley, before returning full-time to South Yorkshire for the 1879–80 season. Lang featured for Attercliffe against Blackburn Rovers in November 1879. Lang also played for the Sheffield Zulus, lining up for them against Chesterfield on 24 November 1879 and Barnsley in January 1880 – he was also briefly secretary for the club. Lang featured for Wednesday over 20 times during the 1880–81 season, captaining them in the opening months. However, for the 1881–82 season he only appreared three times – including the 1882 Wharncliffe Charity Cup Final against Heeley, which Wednesday won 5–0. Lang was also noted playing for Northwich Victoria against Bolton Wanderers in January 1884.
International career
He won two international caps for Scotland, the first on 25 March 1876 in a 4–0 win over Wales and the second on 23 March 1878, scoring a goal in each game.