McShane was captain of Merlyn Rees High School team. He joined the Leeds Academy from Hunslet Hawks in 2006. He was named Junior Academy Player of the Year in 2007 & kicked five goals in their Grand Final win over St. Helens. McShane was named in the England U18 Academy squad to tour Australia in June 2008. McShane signed a five-year contract with the Rhinos in July 2008, keeping him at the club until at least 2013. He made his first team début on the opening day of the 2009 Super League season against Crusaders at Headingley. He made two further appearances in 2009, including his first start against Warrington Wolves. In April 2010, McShane signed for Hull F.C. on a one-month loan deal. He made 4 appearances for the club. McShane made a further 9 Super League appearances for the Rhinos in 2010. He also scored his first try, against. McShane was a replacement in the Leeds side that won the 2012 World Club Challenge, beating Manly Sea Eagles 26-12.
Widnes Vikings (loan)
In May 2012, Widnes Vikings signed McShane on a loan deal for the rest of the season. McShane made 11 appearances during this period, scoring 3 tries and kicking 4 goals.
Return to Leeds Rhinos
In 2013, McShane made 23 appearances for the Rhinos. However, at the end of the season, Leeds Rhinos agreed to release McShane from his contract and placed him on the transfer list.
McShane was signed by Wakefield Trinity Wildcats in November 2013.
Castleford Tigers
In July 2015, McShane joined Castleford Tigers on a two-and-a-half-year contract as part of a deal that saw Scott Moore move the other way on loan. He made his club début against Hull F.C. in the first game of the Super 8s. McShane was ever-present for Castleford Tigers in the 2016 season, appearing in every game. He was an integral part of the 2017 squad that won the League Leaders' Shield and he played in the 2017 Super League Grand Final defeat by the Leeds Rhinos at Old Trafford. McShane was named Castleford Tigers' 3rd Place 2017 Player of the Year. McShane had an outstanding personal season for Castleford in 2018. He dominated the club's end-of-season awards, being recognised as the Fans' Player of the Year, Directors' Player of the Year, Players' Player of the Year, and 1st Place Player of the Year. Since signing for Castleford Tigers McShane has improved and become a fans' favourite. He has made the majority of his appearances at but has covered at halfback.
